Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 14, 2014 at 2:13 PM, Kristofer Hallin
<kristofer.hallin@xxxxxxxxx> wrote:
> Please Nick, stop spamming the list with your patches. I _really_
> doubt that anyone ever will try to get your patches merged since
> you've managed to get banned from vger and got a somewhat flawed
> reputation.
>
> On Thu, Aug 14, 2014 at 8:06 PM, Nick Krause <xerofoify@xxxxxxxxx> wrote:
>> On Thu, Aug 14, 2014 at 2:05 PM, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
>>> I am fixing the bug on at the link, https://bugzilla.kernel.org/show_bug.cgi?id=79931.
>>> This bug report states that in the function, tmio_hc_stop the switch has no needed breaks.
>>> Further more this patch fixes this bug by adding the needed breaks.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
>>> ---
>>>  drivers/usb/host/ohci-tmio.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
>>> index bb40958..d2b5382 100644
>>> --- a/drivers/usb/host/ohci-tmio.c
>>> +++ b/drivers/usb/host/ohci-tmio.c
>>> @@ -100,12 +100,16 @@ static void tmio_stop_hc(struct platform_device *dev)
>>>         switch (ohci->num_ports) {
>>>                 default:
>>>                         dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
>>> +                       break;
>>>                 case 3:
>>>                         pm |= CCR_PM_USBPW3;
>>> +                       break;
>>>                 case 2:
>>>                         pm |= CCR_PM_USBPW2;
>>> +                       break;
>>>                 case 1:
>>>                         pm |= CCR_PM_USBPW1;
>>> +                       break;
>>>         }
>>>         tmio_iowrite8(0, tmio->ccr + CCR_INTC);
>>>         tmio_iowrite8(0, tmio->ccr + CCR_ILME);
>>> --
>>> 1.9.1
>>>
>>
>> If someone wants to send out this patch for me,that would be great :).
>> Nick
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies@xxxxxxxxxxxxxxxxx
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Kristofer,
I understand that too but this patch works and builds I have tested it
completely.
Look I got off on the wrong start and I am starting to improve my repo but seems
impossible if people are just going to forget about my good patches.
Nick

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux