Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 13, 2014 at 12:02 PM,  <Valdis.Kletnieks@xxxxxx> wrote:
> On Wed, 13 Aug 2014 18:50:43 +0400, Max Filippov said:
>
>> No need to trigger it, faking it would be enough, e.g.:
>
>> +                if (++i < 3)
>> +                        skb  = dev_alloc_skb(frag_length + 4);
>> +                else
>> +                        skb = NULL;
>
> Don't bet on this triggering on a real system without some additional
> scaffolding - take a look at what the function is doing, and ask yourself
> how many times it will be called on the average system :)
Seems to be called a lot. In addition I can only build test this as I
don't have the hardware.
Cheers Nick

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux