Re: Etiquette of submitting patches for fixing coding style.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Fri, Oct 26, 2012 at 1:57 AM, Eugene Voronkov <eugene.voronkov@xxxxxxxxx> wrote:
I watched Kroah-Hartman's video[1] on submitting patches where he walks through the process of fixing coding style.  I feel like this would be a good way for me to jump into the process but I need more information.  At what point do code style patches stop being more trouble then they're worth to the maintainers?  For example, running checkpatch.pl against all files is showing around 3 non-trivial style violations per file.  Would a patch fixing 12 violations across 4 files be worth submitting?

Suggestion would be, divide your single patch in separate individual patches with respect to functionality/violations fix.
 

1. http://www.youtube.com/watch?v=LLBrBBImJt4


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux