Re: Build scatterlist covering a process' text segment?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan, it's kmalloc(), not kcalloc().

On 17 Haz 2011, at 18:10, Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote:

> On Fri, Jun 17, 2011 at 02:47:25AM +0200, Arvid Brodin wrote:
> [...]
>>    /**** User page code ****/
>> 
>>    pages = kmalloc(nr_pages * sizeof(*pages), GFP_KERNEL);
> 
> kcalloc?
> 
> You don't need the zeroing but the overflow check might be useful.
> 
>>    if (!pages) {
>>        retval = -ENOMEM;
>>        goto err_pages;
>>    }
> 
> Greetings,
>    Jonathan Neuschäfer
> 
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies@xxxxxxxxxxxxxxxxx
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@xxxxxxxxxxxxxxxxx
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux