* Jaswinder Singh <jaswinder@xxxxxxxxxxxxx> wrote: > I am trying to solve following sparse warnings. Please give me feedback > for the Patch. You can also find updated sparse patches from > http://git.infradead.org/users/jaswinder/sparse-2.6.git > 28 files changed, 140 insertions(+), 18 deletions(-) nice. Could you please split this up into individual commits, and against tip/master: http://people.redhat.com/mingo/tip.git/README Granularity should be roughly per file. (i.e. around 30 commits would be fine) That way if any commit is found to be bad we can unapply/revert it just fine without the rest of your changes. Merging into different topic branches is also easier that way. Ingo -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx Please read the FAQ at http://kernelnewbies.org/FAQ