Re: [PATCH] advansys: use request_firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-07-14 at 08:50 -0600, Matthew Wilcox wrote:
> I'm not quite sure whether my question was answered ...
> 
> When firmware is built in, does
> 1) request_firmware() make a copy of it and then release_firmware free
>    that copy?
> 2) request_firmware() return a pointer to the built-in firmware with
>    release_firmware() being a no-op?
> 3) request_firmware() return a pointer to the built-in firmware with
>    release_firmware() freeing the original?
> 
> Cases 1 and 2 are fine, case 3 is a problem.

Effectively (2).

Actually we do allocate and free the 'struct firmware' but fw->data is
just pointed to the original blob, and then that blob doesn't get freed.

-- 
dwmw2


--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux