On Sun, 23 Mar 2008, Manish Katiyar wrote:
... snip ...
> > list_splice(&d->fifo_list, &packet_list);
> > list_splice(&d->pending_list, &packet_list);
> > INIT_LIST_HEAD(&d->fifo_list);
> > INIT_LIST_HEAD(&d->pending_list);
> > ...
>
> Interesting point Robert, I agree. However not every call to
> list_splice is accompanied by a call to INIT_LIST_HEAD in the
> current code (26.24.2) and I can see this *seem to be buggy* call in
> some of the important files like VM and cache. One such example is
> in
>
> kmem_cache_shrink
> shrink_page_list
>
> etc. and lot of others. Wonder how they work unless we are missing
> something :-)
by the way, in some cases, there is a call to INIT_LIST_HEAD but it
might be a number of lines down in the code so sometimes it's not
obvious. i've noticed a couple of those.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.
http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ
