On 24/08/07, hinko.kocevar@xxxxxxxxxxxx <hinko.kocevar@xxxxxxxxxxxx> wrote: [snip] > > Why would one copy-paste the patch once the diff is in the file? Becourse patches should be send inline and some people apparently don't know how to insert files properly inline into email. > Is the > mailers attach function appropriate for including the files in the message? No. Attachments make it hard to comment on a patch when replying, it's also more work to have to save the attachment before you can view it (when your mailer doesn't let you view attachments directly). Generally, attachments for patches are not welcome - they can be used as a last resort in special cases, but should generally be avoided. For more, please see http://www.kernel.org/pub/linux/docs/lkml/#s1-10 http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt > By copy-paste you can also destroy the whitespace info (tab->space), not > to mention word wrapping issues. Yup - bad thing to do. > Thunderbird sucks at sending copy-pasted patches, but if the patch is > attached as an inline file it is not modified or garbled - just checked > that on the other side in the gmails web interface. > Other apps that tend to work fine are; alpine, pine, mutt, kmail, git-send-email -- Jesper Juhl <jesper.juhl@xxxxxxxxx> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe from this list: send an email with "unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx Please read the FAQ at http://kernelnewbies.org/FAQ
