Re: how to identify what can be removed?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 06, 2007 at 03:39:44PM -0400, Robert P. J. Day wrote:
> 
>   i just want to clarify how to identify how much can be deleted when
> looking at a combination of source files, header files, a Makefile and
> a Kconfig file.
> 
>   consider sound/oss/dmasound/Makefile:
> 
> ==========
> dmasound_pmac-y                 += dmasound_awacs.o \
>                                    trans_16.o dac3550a.o tas_common.o \
>                                    tas3001c.o tas3001c_tables.o \
>                                    tas3004.o tas3004_tables.o
> 
> obj-$(CONFIG_DMASOUND_ATARI)    += dmasound_core.o dmasound_atari.o
> obj-$(CONFIG_DMASOUND_PMAC)     += dmasound_core.o dmasound_pmac.o
> obj-$(CONFIG_DMASOUND_PAULA)    += dmasound_core.o dmasound_paula.o
> obj-$(CONFIG_DMASOUND_Q40)      += dmasound_core.o dmasound_q40.o
> ==========
> 
>   now, there is no longer any CONFIG_DMASOUND_PMAC Kconfig variable,
> so i'm assuming that i can remove that one line from the Makefile, as
> well as the source file dmasound_pmac.c.  so far, easy.

Andrew wanted me to remove the options first (as described in 
Documentation/feature-removal-schedule.txt), and I'll remove this code 
in 2.6.24.

>   in addition, i'm not *entirely* familiar with how a variable of the
> form "dmasound_pmac-y" is processed, but i'm assuming that, since
> dmasound_pmac.c no longer exists, any corresponding source files in
> that list that aren't also referenced elsewhere can also be deleted.
> (in this case, it appears to be the entire list.)
> 
>   does that make sense?  this would remove the vast majority of that
> entire directory, but that looks like the logical conclusion based on
> what i see.
> 
>   thoughts?

Conclusion is correct, but as said above it's already scheduled and I'll 
remove it then.

> rday

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux