On Mon, Dec 25, 2006 at 05:11:35PM +1000, Badai Aqrandista wrote: > I chose this point in the kj todo list: > > - pr_debug() from kernel.h could replace a lot of DPRINTK and similar > macros. > Attached is my first patch to implement that point in > /drivers/macintosh/smu.c. Patch looks good to me. > I've few questions here: > > Can I just send it to kernel-janitors@xxxxxxxxxxxxxx to be discussed there? Yeah, but your mail needs some extra work: - Do not EVER use HTML messages or your message *will* be ignored. - Please inline patches to make it easy to comment on them. Only if your mailer mangles patches attach the patch (preferably as plain text, not base64 encoded). - Add a Signed-off-by line so we can trace who submitted the patch. See Documentation/SubmittingPatches for more information. > Should I make a lot of changes and then post it in kernel janitor list as a > patch? One change per patch is the prefered way. One huge patch with lots of changes is too much to review. > Should I make my git available for kernel janitor maintainer to pull from? You could do both but patches always need to go through the appropriate mailinglist/maintainer by mail (unless your name is "Linus Torvalds"). Erik -- They're all fools. Don't worry. Darwin may be slow, but he'll eventually get them. -- Matthew Lammers in alt.sysadmin.recovery -- Kernelnewbies: Help each other learn about the Linux kernel. Archive: http://mail.nl.linux.org/kernelnewbies/ FAQ: http://kernelnewbies.org/faq/
