Re: [patch 11/20] chardev: GPIO for SCx200: migrate file-ops to shared module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/06, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:

Move read(), write() to common-support file: nsc_gpio.c, rename them
for their new home, and change scx200_gpio's vtable too.  Since these
handlers are already using the gpio_ops vtable-calls, they move with
just the renames.  Fn-decls are added to the header

[snip]
+ssize_t nsc_gpio_write(struct file *file, const char __user * data,
+                      size_t len, loff_t * ppos)

ssize_t nsc_gpio_write(struct file *file, const char __user *data,
                     size_t len, loff_t *ppos)


[snip]
+               case 'p':
+                       printk(KERN_INFO NAME ": GPIO%d pull up disabled\n", m);
+                       amp->gpio_config(m, ~4, 0);
+                       break;
+
+               case 'v':

Get rid of the blank line between "break;" and "case 'v':".


[snip]
+ssize_t nsc_gpio_read(struct file *file, char __user * buf,
+                     size_t len, loff_t * ppos)

ssize_t nsc_gpio_read(struct file *file, char __user *buf,
                    size_t len, loff_t *ppos)


[snip]
+extern ssize_t nsc_gpio_write(struct file *file, const char __user * data,
+                             size_t len, loff_t * ppos);
+
+extern ssize_t nsc_gpio_read(struct file * file, char __user * buf,
+                            size_t len, loff_t * ppos);

extern ssize_t nsc_gpio_write(struct file *file, const char __user *data,
                            size_t len, loff_t *ppos);

extern ssize_t nsc_gpio_read(struct file * file, char __user *buf,
                           size_t len, loff_t *ppos);



--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux