On 12/06/06, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
Shrink scx200_gpio_dump to a single printk with ternary ops. - still coddled in its if 0 (merge with later patch ?) - maybe do pdev_info here too.
(hmm, patch 04/20 seems to have gone missing for me, did you forget to send it?)
+ printk(KERN_INFO NAME ": GPIO-%02u: 0x%08lx %s %s %s %s %s %s %s\n", + index, (unsigned long) config, + (config & 1) ? "OE" : "TS", /* output enabled / tristate */ + (config & 2) ? "PP" : "OD", /* push pull / open drain */ + (config & 4) ? "PUE" : "PUD", /* pull up enabled/disabled */ + (config & 8) ? "LOCKED" : "", /* locked / unlocked */ + (config & 16) ? "LEVEL" : "EDGE", /* level/edge input */ + (config & 32) ? "HI" : "LO", /* trigger on rising/falling edge */ + (config & 64) ? "DEBOUNCE" : ""); /* debounce */
This was previously KERN_DEBUG, but now it's KERN_INFO. Why the change? Is this info really relevant in non-debug scenarios? Like the change otherwise. PS. Not going to look at more patches tonight - need sleep.. -- Jesper Juhl <jesper.juhl@xxxxxxxxx> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- Kernelnewbies: Help each other learn about the Linux kernel. Archive: http://mail.nl.linux.org/kernelnewbies/ FAQ: http://kernelnewbies.org/faq/
