On Tue, May 17, 2005 at 06:48:56AM -0600, Jim Cromie wrote: > folks, > > Ive worked up a fairly trivial patch (attached) to scx200 and scx200_gpio. > Ive gotten the OK from the maintainer (also attached), so Im looking for > advice on how to proceed further. I thought about posting to > kernel-mentors, but one look at the size of work being reviewed there > (plan9 fs), its not where I belong.. Why not? That's the perfict place for this, it doesn't matter as to the size :) > 1. patch above comments out printks in scx200_gpio_write, > maybe better way is to macro-ize them so theyre DBG able. > (should I, and whats an acceptable Kconfig name ?) Used the dev_dbg(), dev_info() and friends macros instead. That's the proper way to do this. thanks, greg k-h -- Kernelnewbies: Help each other learn about the Linux kernel. Archive: http://mail.nl.linux.org/kernelnewbies/ FAQ: http://kernelnewbies.org/faq/
