Re: request_firmware() from probe function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 14, 2005 at 07:49:10PM +0100, Frank.A.Uepping wrote:
> On Monday 14 February 2005 17:35, Greg KH wrote:
> > On Sat, Feb 12, 2005 at 10:56:53AM +0100, Frank.A.Uepping wrote:
> > > Hi,
> > > may I call request_firmware() from the probe function of a PCI driver?
> > 
> > Yes.  Does it not work for you?
> Indeed, but I was not sure whether it is appropriate to wait -- since
> request_firmware() blocks -- for user space (loading firmware to kernel) in a
> bus's driver probe function.  Otherwise we need to use
> request_firmware_nowait(), which is an asynchronous variant of
> request_firmware(), apparently.

You didn't ask if it was "appropriate" or not, only if it was possible
to work properly :)

And yes, I agree, you should call the _nowait() version to be nice to
the rest of the system, and to your user who just called modprobe...

thanks,

greg k-h

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux