Hi I'm porting my 2.4 driver module to 2.6. I've read a bunch to documents on the web about porting including this very helpful one at LWN: http://lwn.net/Articles/driver-porting/ However I've hit a problem, and google searches have turned up nothing. Below is the build o/p: [root@woolyhat driver26]# make V=1 make -C /lib/modules/2.6.5-1.358/build SUBDIRS=/mnt/gromit/scream/v-168/driver26 modules make[1]: Entering directory `/lib/modules/2.6.5-1.358/build' mkdir -p /mnt/gromit/scream/v-168/driver26/.tmp_versions make -f scripts/Makefile.build obj=/mnt/gromit/scream/v-168/driver26 gcc -Wp,-MD,/mnt/gromit/scream/v-168/driver26/.scream.o.d -nostdinc -iwithprefix include -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -pipe -msoft-float -fno-builtin-sprintf -fno-builtin-log2 -fno-builtin-puts -mpreferred-stack-boundary=2 -march=i686 -mregparm=3 -Iinclude/asm-i386/mach-default -Os -fomit-frame-pointer -g -Wdeclaration-after-statement -DINT32 -DLINK_BYTE_WRITE -D -DJEDI_ES2 -O -I/mnt/gromit/scream/v-168/driver26/../share -I/mnt/gromit/scream/v-168/driver26 -DMODULE -DKBUILD_BASENAME=scream -DKBUILD_MODNAME=screamer -c -o /mnt/gromit/scream/v-168/driver26/scream.o /mnt/gromit/scream/v-168/driver26/scream.c <command line>:7:1: macro names must be identifiers /mnt/gromit/scream/v-168/driver26/scream.c: In function `screamer_pci_probe': /mnt/gromit/scream/v-168/driver26/scream.c:2781: warning: passing arg 2 of `request_irq' from incompatible pointer type /mnt/gromit/scream/v-168/driver26/scream.c:2744: warning: ignoring return value of `pci_enable_device', declared with attribute warn_unused_result make[2]: *** [/mnt/gromit/scream/v-168/driver26/scream.o] Error 1 make[1]: *** [/mnt/gromit/scream/v-168/driver26] Error 2 make[1]: Leaving directory `/lib/modules/2.6.5-1.358/build' make: *** [default] Error 2 [root@woolyhat driver26]# The warnings are no big deal but I don't know what the first line means... <command line>:7:1: macro names must be identifiers Is it refering to a problem in the make file or my C file ? Is 7:1 mean line 7 first character, or the other way around ? What does 'macro names must be identifiers' mean ? I suspect its not really a LK question, but I wasn't sure who else to ask. Very grateful for any help. Thanks dom -- Kernelnewbies: Help each other learn about the Linux kernel. Archive: http://mail.nl.linux.org/kernelnewbies/ FAQ: http://kernelnewbies.org/faq/