Re: Function headers in drivers/pci

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 27, 2004 at 06:40:38PM +0200, Tobias Klauser wrote:
> Hi,
> 
> I was going through the code in drivers/pci and noticed, that the function 
> headers sometimes slightly differ.
> 
> e.g. in drivers/pci.c: 55
> 
> unsigned char __devinit
> pci_max_busnr(void)
> {
> ...
> }
> 
> the return type of the function has its own line, while
> 
> e.g. in drivers/pci.c: 140
> 
> int pci_bus_find_capability(struct pci_bus *bus, unsigned int devfn, int cap)
> {
> ...
> }
> 
> the return type is on the same line as the rest of the function header.
> 
> Is there a specific reason for that, or is it just different "tastes" of 
> coding style? ;)

It is different "tastes" due to different people contributing the code
over the years.  I'm about to go fix them all up to be the same, once
2.6.9 is out.

Oh, and I'm converting them all to the style for
pci_bus_find_capability() as that is the proper one.

thanks,

greg k-h

--
Kernelnewbies: Help each other learn about the Linux kernel.
Archive:       http://mail.nl.linux.org/kernelnewbies/
FAQ:           http://kernelnewbies.org/faq/


[Index of Archives]     [Newbies FAQ]     [Linux Kernel Mentors]     [Linux Kernel Development]     [IETF Annouce]     [Git]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux SCSI]     [Linux ACPI]
  Powered by Linux