On Sat, Dec 17, 2016 at 2:18 PM, Liping Zhang <zlpnobody@xxxxxxxxx> wrote: > According to the explanations in nftables wifi: > https://wiki.nftables.org/wiki-nftables/index.php/Performing_Network_Address_Translation_(NAT) > > You should add the following nft rules(I agree this is tricky and > unfriendly for the end user): > # nft add chain nat prerouting { type nat hook prerouting priority 0 \; } > > But unfortunately, even if you add the above rule, you will still fail to > connect to a local server. > Correct, doesn't change anything. > Now add another nft rules listed below, you can probably make everything > work fine: > # nft add chain nat output { type nat hook output priority 0 \; } > Haven't tried it. Why would it change things? Have you tried it? > [ cc netfilter-dev group ] > > For loopback connection, the request packets will traverse: > OUTPUT->POSTROUTING->PREROUTING->INPUT > and the source ip will be modified in nat POSTROUTING hook. The problem is that the IP incorrectly changes to the wrong one. > > Meanwhile the reply packets will also traverse: > OUTPUT->POSTROUTING->PREROUTING->INPUT > and if nat OUTPUT hook exist, the destination ip will be modified > in it, and re-route will happen. Otherwise, the destination ip will > be modified at nat PREROUTING hook, and the dst entry will > be dropped. In such situation(i.e. nat OUTPUT doesn't exist), > we will try to do routing lookup and packets will be dropped > at ip_route_input_slow->martian_destination. I think that all throughout this thread we've been analysing the behaviour in the broken scenario instead of just fixing it (which I see your latest patch may actually do, and that's good). It doesn't matter where the packet goes through after it's been wrongly rewritten, the problem is that it has. > > Furthermore, if ipt_rpfilter is configured, the reply packet maybe > dropped at there. > It's off. > In iptables, nat output chain always exists, so there's no > such problem. > > But I think that enforcing the user to add a nat output chain > in nftables is not a good idea, so probably we need a following > patch(I only list the ipv4 part): Interesting. Maybe that's why it continued to work after iptables has already been loaded on the box. As said above though, I believe the problem is the masquerade setting the wrong ip, and not (only?) the fact that my setup happens to work with iptables but doesn't with nftables. Don't you agree? Thanks, Tom. > > diff --git a/net/ipv4/netfilter/nf_nat_l3proto_ipv4.c > b/net/ipv4/netfilter/nf_nat_l3proto_ipv4.c > index f8aad03..5bc9b22 100644 > --- a/net/ipv4/netfilter/nf_nat_l3proto_ipv4.c > +++ b/net/ipv4/netfilter/nf_nat_l3proto_ipv4.c > @@ -344,8 +344,21 @@ nf_nat_ipv4_in(void *priv, struct sk_buff *skb, > > ret = nf_nat_ipv4_fn(priv, skb, state, do_chain); > if (ret != NF_DROP && ret != NF_STOLEN && > - daddr != ip_hdr(skb)->daddr) > - skb_dst_drop(skb); > + daddr != ip_hdr(skb)->daddr) { > + const struct rtable *rt = skb_rtable(skb); > + int err; > + > + if (rt) { > + if (rt->rt_flags & RTCF_LOCAL) { > + err = ip_route_me_harder(state->net, skb, > + RTN_UNSPEC); > + if (err < 0) > + ret = NF_DROP_ERR(err); > + } else { > + skb_dst_drop(skb); > + } > + } > + } > > return ret; > } > >> >> With this, connections to localhost fail because the masquerade line >> sets the source IP to that of the wlp1s0 interface, and not of the lo >> interface. >> >> Here is output from the log: >> IN=lo OUT= MAC=00:00:00:00:00:00:00:00:00:00:00:00:08:00 >> SRC=192.168.86.18 DST=127.0.0.1 LEN=60 TOS=0x00 PREC=0x00 TTL=64 >> ID=64500 DF PROTO=TCP SPT=36844 DPT=8000 WINDOW=43690 RES=0x00 SYN >> URGP=0 >> >> You can see how the source ip is wrong. This is from running "curl" >> trying to connect to a local http server on port 8000. >> >> Removing the masquerade line, or changing it to: "oifname wlp1s0 >> masquerade" fixes it, but this is just a workaround that will fail in >> more complex situations. >> >> I would have loved to provide you with tracing information, but >> unfortunately I never got that to work for me. >> >> Tried with kernels: 4.8.12 and 4.4.35 on arch linux. Nft version is 0.6. >> >> Please let me know if there's any other info you'd like me to provide you with. >> >> Thanks, >> Tom. >> -- >> To unsubscribe from this list: send the line "unsubscribe netfilter" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
