Re: [ANNOUNCE] ipset 6.16.1 released

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 10 Jan 2013, Andreas Herz wrote:

> On 10/01/13 at 00:12, Jan Engelhardt wrote:
> > 
> > On Wednesday 2013-01-09 23:44, Jozsef Kadlecsik wrote:
> > >-			KCFLAGS="-DPACKAGE_VERSION=$(PACKAGE_VERSION)" \
> > >+			KCFLAGS="-DPACKAGE_VERSION=$(PACKAGE_VERSION)-DINLINE=$(INLINE)" \
> > 
> > You seem to be missing a space before -DINL
> 
> I also changed this in the patch, but still:
> 
> /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:
> In function `hash_ip4_add':
> /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:444:
> sorry, unimplemented: inlining failed in call to 'hash_ip4_data_next':
> function body not available
> /usr/src/redhat/BUILD/ipset-6.16.1/kernel/include/linux/netfilter/ipset/ip_set_ahash.h:485:
> sorry, unimplemented: called from here

So in the generated config.h you can find the next, right?

/* Inline in prototype supported. */
#define INLINE_IN_PROTOTYPE 1

> Don't bother too much, as i can build it on another machine, but i'm
> curious why it won't work and how it should be fixed.

The old gcc does not accept the "inline" keyword in the function 
prototype. The patch attempted to detect it and depending on the result, 
the keyword is used or not.

Best regards,
Jozsef
-
E-mail  : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux