On Tue, 2012-05-15 at 10:59 -0700, Joe Perches wrote: > On Tue, 2012-05-15 at 13:45 -0400, David Miller wrote: > > From: Joe Perches <joe@xxxxxxxxxxx> > > Date: Mon, 14 May 2012 00:56:24 -0700 > > > > > net_ratelimit() like __ratelimit() is too easy to misuse. > > > > > > Add simplifying macros similar to pr_<level>_ratelimited > > > that combines the test of net_ratelimit and logging. > > > > > > Joe Perches (2): > > > net: Add net_ratelimited_function and net_<level>_ratelimited macros > > > net: Convert net_ratelimit uses to net_<level>_ratelimited > > > > These look fine to me so I've applied them to net-next and am > > sanity checking the build right now. > > OK, but fyi, there's a possible issue with !CONFIG_DEBUG > builds because these patches converted some uses of > if (net_ratelimit()) > printk(KERN_DEBUG ... > to > net_dbg_ratelimited() > > These messages are no longer emitted when DEBUG isn't defined > and not using dynamic_debug. I'm not sure that's a real > problem, but it's a difference. > > I could produce a net_printk_ratelimited that would keep > the original behavior if necessary. > > net_printk_ratelimited(KERN_DEBUG etc...) Oops. Yes, please do that, mac80211 doesn't have DEBUG yet johannes -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
