[ulogd2] Small fix for table ulog2 structure for postgresql and two other questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,
1. There is a small issue when we create databse structure in postgresql. Table "ulog2" has column "timestamp" with default value "now". This is incorrect. It means all tuples in this table will have the same value, "now" of time when table was created. I guess it isn't usefull. This small patch resolves this issue.

--- a/doc/pgsql-ulogd2.sql
+++ b/doc/pgsql-ulogd2.sql
@@ -61,7 +61,7 @@ CREATE TABLE ulog2 (
   ip_fragoff smallint default NULL,
   label smallint default NULL,
   mac_id bigint default NULL,
-  timestamp timestamp NOT NULL default 'now'
+  timestamp timestamp NOT NULL default now()
 ) WITH (OIDS=FALSE);

 CREATE INDEX ulog2_oob_family ON ulog2(oob_family);


2. Ulogd2 obtains list of columns from table defined in config. And fails if can't match column name with any name of output key in used plugins. Also ignores first column from table which isn't mentioned in doc. So when we want to have custom columns in table we have to create additional database object "view" to provide proper information for ulogd2. Meseems it can be done in a bit cleaner way: let columns with first char of name "_" (underscore) will be ignored by stack. In this case "view" wouldn't be need to be used.

3. File README contains information about homepage and mailinglist. It seems outdated.

(I hope this malinglist is correct for ulogd2)
Regards,
Marcin
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux