Re: [PATCH] [connlimit] connlimit-above early loop termination

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/11/2011 12:00 PM, Patrick McHardy wrote:
On 11.02.2011 17:22, Stefan Berger wrote:
The patch below introduces an early termination of the loop that is
counting matches. It terminates once the counter has exceeded the
threshold provided by the user. There's no point in continuing the loop
afterwards and looking at other entries.

It plays together with the following code further below:

return (connections>  info->limit) ^ info->inverse;

where connections is the result of the counted connection, which in turn
is the matches variable in the loop. So once

         ->  matches = info->limit + 1
alias   ->  matches>  info->limit
alias   ->  matches>  threshold

we can terminate the loop.

Applied, thanks Stefan.
I am currently creating a derivative of this module for a slightly different purpose. While testing that one and not using the -m state --state -NEW in front of the -m connlimit, I saw that that shortcut doesn't work properly but keeps on adding entries into the list. So, unfortunately I have to withdraw that patch. I apologize and I'll send a patch for this.

  Regards,
     Stefan
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux