Hi Patrick, On Wed, 2 Feb 2011, Patrick McHardy wrote: > Add some #ifdefs to unconditionally return false in > ip_set_get_ip6_port() when CONFIG_IPV6=n and convert > to ipv6_skip_exthdr() to avoid pulling in the ip6_tables > module when loading ipset. You left out checking fragmented packets. Is it intentional? > A slightly more code-saving alternative would be to add > a dummy inline function or ifdef the callsites. Please > let me know which way you prefer. A dummy inline looks nicer to me, because that way the IPv6 and non-IPv6 cases were clearly separated. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
