Re: [PATCH libnetfilter_queue 1/3] Non-modified payload arguments are pointer-to-const.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Favro wrote:
> The payload parameters to nfq_set_verdict(), nfq_set_verdict2(), and
> nfq_set_verdict_mark() are not modified by those functions, and
> therefore should have datatype pointer-to-const.  This both causes the
> source-code to more effectively represent what is the purpose of the
> parameter, and eliminates the need to cast away const-ness when calling
> the functions with compilers that enforce strict casting.  All existing
> calling code should not need modification as pointer-to-X automatically
> converts to pointer-to-const-X.

This doesn't seem to break ABI so I'm fine with them. Applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux