RE: [ANNOUNCEMENT] ipset-3.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hello,
> 
> I'm happy to announce ipset release 3.1. A few minor bugs were
> fixed and some cleanups added:

I'm a few errors when compiling this version on Centos 5.3, kernel
2.6.18-128.4.1.el5.centos.plus-i686.

/usr/local/src/ipset/ipset-3.1/kernel/ip_set_iptree.c: In function
'iptree_create':
/usr/local/src/ipset/ipset-3.1/kernel/ip_set_iptree.c:285: warning:
format '%lu' expects type 'long unsigned int', but argument 2 has type
'unsigned int'
/usr/local/src/ipset/ipset-3.1/kernel/ip_set_iptree.c:285: warning:
format '%zu' expects type 'size_t', but argument 3 has type 'long
unsigned int'

When I switched arguments 2 and 3 for function ip_set_printk(),these
errors are gone.

> - Fix the definition of 'bool' for kernels <= 2.6.18 (Jan
> Engelhardt)

This also generates an error for me.

/usr/local/src/ipset/ipset-3.1/kernel/ip_set_setlist.c:20: error:
redefinition of typedef 'bool'
include/linux/types.h:36: error: previous declaration of 'bool' was here
/usr/local/src/ipset/ipset-3.1/kernel/ip_set_setlist.c:21: error:
redeclaration of enumerator 'false'
include/linux/stddef.h:16: error: previous definition of 'false' was
here
/usr/local/src/ipset/ipset-3.1/kernel/ip_set_setlist.c:21: error:
redeclaration of enumerator 'true'
include/linux/stddef.h:18: error: previous definition of 'true' was here

When I changed <= into < it compiled fine.

I am by no means a C developer, so please correct me if I'm doing the
wrong thing. I just played around and with these small changes I have
ipset compiling cleanly. Don't know if the changes are correct and
didn't test yet if everything works though.

I attached one diff for both files.


Grts,
Rob

Attachment: ipset-3.1-centos-53-2.6.18-128.4.1.el5.centos.plus-i686.diff
Description: Binary data


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux