Re: [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy Whitcroft wrote:
On Wed, Nov 19, 2008 at 07:08:17PM +0100, Patrick McHardy wrote:
Andy Whitcroft wrote:
It seems that all of the include/netfilter_{ipv4,ipv6}/{ipt,ip6t}_*.h which
share constants include the corresponding include/netfilter/xp_*.h files.
Neither ipt_policy.h not ip6t_policy.h do.  Make these consistant with
the norm.
Does this actually fix a bug, or is it just for added consistency?

It was reported by an Ubuntu user who was compiling against them.  From
my point of view it seemed clearly inconsistant and therefore most likely
wrong.  So it seemed reasonable to fix it and push it upstream, if
there was a reason I was sure you'd soon put me straight.

I'm mainly asking in order to decide whether to push it for
2.7.28 or 2.6.29. So did the user report a compilation error
or something like that?
--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux