Re: [PATCH 1/1] netfilter: ip{,6}t_policy.h should include xp_policy.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Wednesday 2008-11-19 19:08, Patrick McHardy wrote:

Andy Whitcroft wrote:
It seems that all of the include/netfilter_{ipv4,ipv6}/{ipt,ip6t}_*.h which
share constants include the corresponding include/netfilter/xp_*.h files.
Neither ipt_policy.h not ip6t_policy.h do.  Make these consistant with
the norm.
Does this actually fix a bug, or is it just for added consistency?

This can only be consistency, because every compile error would
be easy to fix by inclusion of xt_policy.h in the corresponding
.c file.

It would also be easily fixed by this patch. Lets see what Andy
has to say.

Which reminds me, when can we get rid of the ipt_*h files?

There is external code using these headers, so not at this point.
We could schedule them for removal, but I don't see point, keeping
those headers don't cause any maintenance work.

--
To unsubscribe from this list: send the line "unsubscribe netfilter" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux