Adrian Bunk wrote: > On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote: > >>From: Adrian Bunk <bunk@xxxxxxxxx> >>Date: Mon, 29 Jan 2007 01:00:11 +0100 >> >>>"depends on IPV6" would fix the bug - but it would also make >>>NF_CONNTRACK_H323 unavailable for all people without IPV6 support in >>>their kernel. >> >>Yes, that is an issue. >> >>I guess with some slightly ugly ifdefs we could support the >>whole matrix of possibilities. But perhaps that's undesirable >>for another reason. >>... > > > This depends on what NF_CONNTRACK_H323=y, IPV6=m is supposed to be: > - not allowed (NF_CONNTRACK_H323 must be modular) or > - NF_CONNTRACK_H323 can only be used for IPV4 > > My patch implements the first case. Unfortunately a few ifdefs aren't enough to support IPV6=m, NF_CONNTRACK_H323=y. For now I think Adrian's patch is the best solution (IPV6=m isn't that useful anyway since it will normally get loaded automatically when the first program attempts to open an AF_INET6 socket and can't be unloaded), but I'll look into moving the route lookup to the netfilter AF ops in 2.6.21 so we can also support that configuration. Acked-by: Patrick McHardy <kaber@xxxxxxxxx>
