Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote: > With current-ish Linus 2.6 BK, I'm seeing this: > > net/ipv4/netfilter/ipt_hashlimit.c:96: warning: type defaults to `int' in declaration of `DECLARE_LOCK' > net/ipv4/netfilter/ipt_hashlimit.c:96: warning: parameter names (without types) in function declaration > > Looks like ipt_hashlimit.c is missing an include? Indeed. It should include lockhelp.h directly. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- ===== net/ipv4/netfilter/ipt_hashlimit.c 1.10 vs edited ===== --- 1.10/net/ipv4/netfilter/ipt_hashlimit.c 2005-03-11 07:06:22 +11:00 +++ edited/net/ipv4/netfilter/ipt_hashlimit.c 2005-03-11 22:56:24 +11:00 @@ -37,6 +37,7 @@ #include <linux/netfilter_ipv4/ip_tables.h> #include <linux/netfilter_ipv4/ipt_hashlimit.h> +#include <linux/netfilter_ipv4/lockhelp.h> /* FIXME: this is just for IP_NF_ASSERRT */ #include <linux/netfilter_ipv4/ip_conntrack.h>
