There are alot of ppl working on this it's good to see activity like this. --- Matthew Strait <quadong@xxxxxxxxxxxxxxxxxxxxx> wrote: > > - I can't see any locking in your code, and I don't think it's SMP safe > > I'm not experienced in this. Could you point me at some docs or examples > of how to do this? > Documentation/spinlocks.txt describes how/why/when. I have some non linux related experience with this. Basically if you do a ctr++;(on 2 CPUs) there is a read and write if one CPU reads 5 the other CPU needs to wait for the first to write 6 to memory or you will get 6 not 7. > > - Did you consider basing your work on top of libqsearch? > > (http://www.cartel-securite.fr/pbiondi/libqsearch.html) > > I actually hadn't heard of that before. I've now looked at the > documentation for it, but I'm still not clear on whether it does regular > expressions out of the box, or whether we'd have to graft that on. Given > that I'd rather our patch not be dependent on another patch, I think I'll > stick to the way we do it now unless that's a major barrier to getting > included in patch-o-matic. > Looks cool, I'd be interested in seeing this implemented just for the benchmarks. It looks like it precompiles the expressions, so I guess any input could be used with the correct ?user space? interpretor. > Thanks for the critique. Thanks for l7. > > -Matthew -Mike __________________________________ Do you Yahoo!? Yahoo! Finance: Get your refund fast by filing online. http://taxes.yahoo.com/filing.html
