Re: Netfilter problem with new 2.4.22

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 18, 2003 at 11:40:02PM +0200, Patrick McHardy wrote:
> Hi Diadon,
> the problem seems to be that a dst for local input doesn't carry pmtu 
> information, the pmtu is set by rt_set_nexthop which is skipped for
> local input. 

Thanks for debugging the problem, Patrick.
 
> I've attached two possible fixes for this. The first one restores
> behaviour from before the routing changes for LOCAL_OUT, the other one
> removes the check since obviously "Never happens" is not true anymore
> (and it is not an error). Another possibility would be something like
> "if (nskb->dst->pmtu && nskb->len > nskb->dst->pmtu)  ..."
> Someone from the coreteam should comment which solution is prefered.

I'd actually prefer the last solution (together with a comment why
nskb->dst-pmtu can be zero). 

I've included the patch into 'submitted' (will send it to davem later)

> Regards,
> Patrick

-- 
- Harald Welte <laforge@xxxxxxxxxxxxx>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Attachment: pgp00552.pgp
Description: PGP signature


[Index of Archives]     [Linux Netfilter Development]     [Linux Kernel Networking Development]     [Netem]     [Berkeley Packet Filter]     [Linux Kernel Development]     [Advanced Routing & Traffice Control]     [Bugtraq]

  Powered by Linux