Re: ulogd: out of bounds array access in ulogd_filter_HWHDR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-01-13, at 13:30:01 +0100, Pablo Neira Ayuso wrote:
> On Mon, Jan 13, 2025 at 11:12:01AM +0000, Jeremy Sowden wrote:
> > On 2025-01-13, at 10:33:10 +0000, James Dingwall wrote:
> [...]
> > > --- filter/ulogd_filter_HWHDR.c.orig	2025-01-13 09:25:18.937977335 +0000
> > > +++ filter/ulogd_filter_HWHDR.c	2025-01-13 09:25:51.337824820 +0000
> > > @@ -109,7 +109,7 @@
> > >  	},
> > >  };
> > >  
> > > -static char hwmac_str[MAX_KEY - START_KEY][HWADDR_LENGTH];
> > > +static char hwmac_str[(MAX_KEY + 1) - START_KEY][HWADDR_LENGTH];
> > >  
> > >  static int parse_mac2str(struct ulogd_key *ret, unsigned char *mac,
> > >  			 int okey, int len)
> > 
> > This was fixed a couple of years ago:
> > 
> >   https://git.netfilter.org/ulogd2/commit/?id=49f6def6fcbaf01f395fbe00543a9ab2c4bb106e
> > 
> > and the fix should have made it into the Debian & Ubuntu packages.  I
> > will investigate.
> 
> I am going to launch a new release to help this propagate to distros.

Thanks, Pablo.  I was going to request one. :)

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux