Re: [PATCH v5 1/3] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2025. 01. 06. 8:48 keltezéssel, Jozsef Kadlecsik írta:
On Mon, 6 Jan 2025, Szőke Benjamin wrote:

2025. 01. 05. 22:27 keltezéssel, Andrew Lunn írta:
On Sun, Jan 05, 2025 at 09:34:52PM +0100, egyszeregy@xxxxxxxxxxx wrote:
From: Benjamin Szőke <egyszeregy@xxxxxxxxxxx>

Merge xt_*.h, ipt_*.h and ip6t_*.h header files, which has
same upper and lower case name format.

Add #pragma message about recommended to use
header files with lower case format in the future.

It looks like only patch 1/3 make it to the list.

Also, with a patchset, please include a patch 0/X which gives the big
picture of what the patchset does. The text will be used for the merge
commit, so keep it formal. 'git format-patch --cover-letter' will
create the empty 0/X patch you can edit, or if you are using b4 prep,
you can use 'b4 prep --edit-cover' and then 'b4 send' will
automatically generate and send it.

https://docs.kernel.org/process/maintainer-netdev.html
https://docs.kernel.org/process/submitting-patches.html

     Andrew

https://lore.kernel.org/lkml/20250105233157.6814-1-egyszeregy@xxxxxxxxxxx/T/

It is terribly chaotic how slowly start to appear the full patch list in the mailing list website. It's really time to replace 1990s dev technology with something like GitLab or GitHub developing style can provide in 2024.

No, it was your fault in the v5 series of your patches: you managed to send all the patches in a single email instead of separated ones.

Something is not OK with your e-mail processing:

- 1. [PATCH v7 0/3] which is the cover letter, is appering really slowly in the list after [PATCH v7 1/3], [PATCH v7 2/3], [PATCH v7 3/3] were arrived. This is why I made v7 after v6, because after 10 minutes i still could not see that it is successfully arrived in the mailing list, I fustrated about it again went wrong.


- 2. Patch name visible is buggy:
[PATCH v7 0/3] netfilter: x_tables: Merge xt_*.c files
2025-01-05 23:31 UTC  (4+ messages)
[PATCH v7 1/3] netfilter: x_tables: Merge xt_*.h and ipt_*.h files which has same name
[PATCH v7 2/3] netfilter: x_tables: Merge xt_*.c "
[PATCH v7 3/3] netfilter: x_tables: Adjust code style for xt_*.h/c and ipt_*.h files

[PATCH v7 2/3] netfilter: x_tables: Merge xt_*.c " -> half of real name missing? Real name was: "Merge xt_*.c files which has same name."



Best regards,
Jozsef





[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux