Re: [PATCH nf] netfilter: nf_tables: imbalance in flowtable binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pablo,

On Thu, Jan 02, 2025 at 04:44:43PM +0100, Pablo Neira Ayuso wrote:
> All these cases cause imbalance between BIND and UNBIND calls:
> 
> - Delete an interface from a flowtable with multiple interfaces
> 
> - Add a (device to a) flowtable with --check flag
> 
> - Delete a netns containing a flowtable
> 
> - In an interactive nft session, create a table with owner flag and
>   flowtable inside, then quit.
> 
> Fix it by calling FLOW_BLOCK_UNBIND when unregistering hooks, then
> remove late FLOW_BLOCK_UNBIND call when destroying flowtable.
> 
> Fixes: ff4bf2f42a40 ("netfilter: nf_tables: add nft_unregister_flowtable_hook()")
> Reported-by: Phil Sutter <phil@xxxxxx>
> Signed-off-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Tested-by: Phil Sutter <phil@xxxxxx>

Added printk calls for debugging and recreated the above scenarios, no
imbalance found. Thanks for your fix!

I have to rebase my pending patch series upon this one now. :)

Cheers, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux