Re: [PATCH net-next v2] net: reformat kdoc return statements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 05, 2024 at 08:59:14AM -0800, Jakub Kicinski wrote:
> kernel-doc -Wall warns about missing Return: statement for non-void
> functions. We have a number of kdocs in our headers which are missing
> the colon, IOW they use
>  * Return some value
> or
>  * Returns some value
> 
> Having the colon makes some sense, it should help kdoc parser avoid
> false positives. So add them. This is mostly done with a sed script,
> and removing the unnecessary cases (mostly the comments which aren't
> kdoc).
> 
> Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
> Acked-by: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx>
> Reviewed-by: Edward Cree <ecree.xilinx@xxxxxxxxx>
> Acked-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>

For the netfilter chunks:

Acked-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux