Szőke Benjamin <egyszeregy@xxxxxxxxxxx> wrote: > and lower case *.h files can be merged to a common header files like > "xt_dscp_common.h" but what about the *.c sources? For example if xt_DSCP.c > removed and its content merged to xt_dscp.c before, what is the plan with > kernel config options of CONFIG_NETFILTER_XT_TARGET_DSCP which was made for > only xt_DSCP.c source to use in Makefile? Can we remove all of > CONFIG_NETFILTER_XT_TARGET* config in the future which will lost their *.c > source files? Sure. > obj-$(CONFIG_NETFILTER_XT_TARGET_DSCP) += xt_DSCP.o > ... This line goes away. > obj-$(CONFIG_NETFILTER_XT_MATCH_DSCP) += xt_dscp.o This line is changed to obj-$(CONFIG_NETFILTER_XT_DSCP) += xt_dscp.o Kconfig file NETFILTER_XT_TARGET/MATCH_DSCP are changed to select new NETFILTER_XT_MATCH_DSCP. This has been done before, see e.g. 28b949885f80 ("netfilter: xtables: merge xt_MARK into xt_mark") you can follow this almost 1:1.