Re: [PATCH net-next] net: reformat kdoc return statements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 15.11.24 17:36, Jakub Kicinski wrote:
> kernel-doc -Wall warns about missing Return: statement for non-void
> functions. We have a number of kdocs in our headers which are missing
> the colon, IOW they use
>  * Return some value
> or
>  * Returns some value
> 
> Having the colon makes some sense, it should help kdoc parser avoid
> false positives. So add them. This is mostly done with a sed script,
> and removing the unnecessary cases (mostly the comments which aren't
> kdoc).
> 
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> LMK if I should have split this into smaller chunks, I don't really
> expect much review here, TBH.
> ---
> CC: pablo@xxxxxxxxxxxxx
> CC: linux@xxxxxxxxxxxxxxx
> CC: richardcochran@xxxxxxxxx
> CC: johannes@xxxxxxxxxxxxxxxx
> CC: loic.poulain@xxxxxxxxxx
> CC: ryazanov.s.a@xxxxxxxxx
> CC: dsahern@xxxxxxxxxx
> CC: wintera@xxxxxxxxxxxxx
[...]
>  include/net/iucv/iucv.h            | 30 ++++++++++----------


Thank you Jakub.
For the iucv part:
Acked-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux