Hi Florian, kernel test robot noticed the following build errors: [auto build test ERROR on netfilter-nf/main] [also build test ERROR on linus/master v6.12-rc6 next-20241107] [cannot apply to nf-next/master horms-ipvs/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-conntrack-add-conntrack-event-timestamp/20241108-034444 base: https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main patch link: https://lore.kernel.org/r/20241107194117.32116-1-fw%40strlen.de patch subject: [PATCH nf-next] netfilter: conntrack: add conntrack event timestamp config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241108/202411081404.HNJI5WdG-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411081404.HNJI5WdG-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411081404.HNJI5WdG-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from net/netfilter/nf_conntrack_core.c:15: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:10: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from net/netfilter/nf_conntrack_core.c:15: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from net/netfilter/nf_conntrack_core.c:15: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from net/netfilter/nf_conntrack_core.c:15: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from net/netfilter/nf_conntrack_core.c:41: In file included from include/net/netfilter/nf_conntrack_core.h:18: include/net/netfilter/nf_conntrack_ecache.h:24:2: error: unknown type name 'local64_t'; did you mean 'local_t'? 24 | local64_t timestamp; /* event timestamp, in nanoseconds */ | ^~~~~~~~~ | local_t include/asm-generic/local.h:25:3: note: 'local_t' declared here 25 | } local_t; | ^ In file included from net/netfilter/nf_conntrack_core.c:41: In file included from include/net/netfilter/nf_conntrack_core.h:18: >> include/net/netfilter/nf_conntrack_ecache.h:118:6: error: call to undeclared function 'local64_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 118 | if (local64_read(&e->timestamp) && READ_ONCE(e->cache) == 0) | ^ >> include/net/netfilter/nf_conntrack_ecache.h:119:3: error: call to undeclared function 'local64_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 119 | local64_set(&e->timestamp, ktime_get_real_ns()); | ^ 7 warnings and 3 errors generated. -- In file included from net/netfilter/nf_conntrack_ecache.c:14: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:10: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from net/netfilter/nf_conntrack_ecache.c:14: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from net/netfilter/nf_conntrack_ecache.c:14: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from net/netfilter/nf_conntrack_ecache.c:14: In file included from include/linux/netfilter.h:6: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from net/netfilter/nf_conntrack_ecache.c:25: In file included from include/net/netfilter/nf_conntrack_core.h:18: include/net/netfilter/nf_conntrack_ecache.h:24:2: error: unknown type name 'local64_t'; did you mean 'local_t'? 24 | local64_t timestamp; /* event timestamp, in nanoseconds */ | ^~~~~~~~~ | local_t include/asm-generic/local.h:25:3: note: 'local_t' declared here 25 | } local_t; | ^ In file included from net/netfilter/nf_conntrack_ecache.c:25: In file included from include/net/netfilter/nf_conntrack_core.h:18: >> include/net/netfilter/nf_conntrack_ecache.h:118:6: error: call to undeclared function 'local64_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 118 | if (local64_read(&e->timestamp) && READ_ONCE(e->cache) == 0) | ^ >> include/net/netfilter/nf_conntrack_ecache.h:119:3: error: call to undeclared function 'local64_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 119 | local64_set(&e->timestamp, ktime_get_real_ns()); | ^ >> net/netfilter/nf_conntrack_ecache.c:168:6: error: call to undeclared function 'local64_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 168 | if (local64_read(&e->timestamp)) | ^ >> net/netfilter/nf_conntrack_ecache.c:169:3: error: call to undeclared function 'local64_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 169 | local64_set(&e->timestamp, ktime_get_real_ns()); | ^ net/netfilter/nf_conntrack_ecache.c:318:2: error: call to undeclared function 'local64_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 318 | local64_set(&e->timestamp, ts); | ^ 7 warnings and 6 errors generated. -- In file included from net/netfilter/nf_conntrack_netlink.c:25: In file included from include/linux/security.h:33: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from net/netfilter/nf_conntrack_netlink.c:25: In file included from include/linux/security.h:35: In file included from include/linux/bpf.h:31: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from net/netfilter/nf_conntrack_netlink.c:25: In file included from include/linux/security.h:35: In file included from include/linux/bpf.h:31: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from net/netfilter/nf_conntrack_netlink.c:25: In file included from include/linux/security.h:35: In file included from include/linux/bpf.h:31: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from net/netfilter/nf_conntrack_netlink.c:38: In file included from include/net/netfilter/nf_conntrack_core.h:18: include/net/netfilter/nf_conntrack_ecache.h:24:2: error: unknown type name 'local64_t'; did you mean 'local_t'? 24 | local64_t timestamp; /* event timestamp, in nanoseconds */ | ^~~~~~~~~ | local_t include/asm-generic/local.h:25:3: note: 'local_t' declared here 25 | } local_t; | ^ In file included from net/netfilter/nf_conntrack_netlink.c:38: In file included from include/net/netfilter/nf_conntrack_core.h:18: >> include/net/netfilter/nf_conntrack_ecache.h:118:6: error: call to undeclared function 'local64_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 118 | if (local64_read(&e->timestamp) && READ_ONCE(e->cache) == 0) | ^ >> include/net/netfilter/nf_conntrack_ecache.h:119:3: error: call to undeclared function 'local64_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 119 | local64_set(&e->timestamp, ktime_get_real_ns()); | ^ >> net/netfilter/nf_conntrack_netlink.c:392:12: error: call to undeclared function 'local64_read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 392 | u64 ts = local64_read(&e->timestamp); | ^ 7 warnings and 4 errors generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for GET_FREE_REGION Depends on [n]: SPARSEMEM [=n] Selected by [m]: - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m] vim +/local64_read +118 include/net/netfilter/nf_conntrack_ecache.h 20 21 struct nf_conntrack_ecache { 22 unsigned long cache; /* bitops want long */ 23 #ifdef CONFIG_NF_CONNTRACK_TIMESTAMP > 24 local64_t timestamp; /* event timestamp, in nanoseconds */ 25 #endif 26 u16 ctmask; /* bitmask of ct events to be delivered */ 27 u16 expmask; /* bitmask of expect events to be delivered */ 28 u32 missed; /* missed events */ 29 u32 portid; /* netlink portid of destroyer */ 30 }; 31 32 static inline struct nf_conntrack_ecache * 33 nf_ct_ecache_find(const struct nf_conn *ct) 34 { 35 #ifdef CONFIG_NF_CONNTRACK_EVENTS 36 return nf_ct_ext_find(ct, NF_CT_EXT_ECACHE); 37 #else 38 return NULL; 39 #endif 40 } 41 42 static inline bool nf_ct_ecache_exist(const struct nf_conn *ct) 43 { 44 #ifdef CONFIG_NF_CONNTRACK_EVENTS 45 return nf_ct_ext_exist(ct, NF_CT_EXT_ECACHE); 46 #else 47 return false; 48 #endif 49 } 50 51 #ifdef CONFIG_NF_CONNTRACK_EVENTS 52 53 /* This structure is passed to event handler */ 54 struct nf_ct_event { 55 struct nf_conn *ct; 56 u32 portid; 57 int report; 58 }; 59 60 struct nf_exp_event { 61 struct nf_conntrack_expect *exp; 62 u32 portid; 63 int report; 64 }; 65 66 struct nf_ct_event_notifier { 67 int (*ct_event)(unsigned int events, const struct nf_ct_event *item); 68 int (*exp_event)(unsigned int events, const struct nf_exp_event *item); 69 }; 70 71 void nf_conntrack_register_notifier(struct net *net, 72 const struct nf_ct_event_notifier *nb); 73 void nf_conntrack_unregister_notifier(struct net *net); 74 75 void nf_ct_deliver_cached_events(struct nf_conn *ct); 76 int nf_conntrack_eventmask_report(unsigned int eventmask, struct nf_conn *ct, 77 u32 portid, int report); 78 79 bool nf_ct_ecache_ext_add(struct nf_conn *ct, u16 ctmask, u16 expmask, gfp_t gfp); 80 #else 81 82 static inline void nf_ct_deliver_cached_events(const struct nf_conn *ct) 83 { 84 } 85 86 static inline int nf_conntrack_eventmask_report(unsigned int eventmask, 87 struct nf_conn *ct, 88 u32 portid, 89 int report) 90 { 91 return 0; 92 } 93 94 static inline bool nf_ct_ecache_ext_add(struct nf_conn *ct, u16 ctmask, u16 expmask, gfp_t gfp) 95 { 96 return false; 97 } 98 #endif 99 100 static inline void 101 nf_conntrack_event_cache(enum ip_conntrack_events event, struct nf_conn *ct) 102 { 103 #ifdef CONFIG_NF_CONNTRACK_EVENTS 104 struct net *net = nf_ct_net(ct); 105 struct nf_conntrack_ecache *e; 106 107 if (!rcu_access_pointer(net->ct.nf_conntrack_event_cb)) 108 return; 109 110 e = nf_ct_ecache_find(ct); 111 if (e == NULL) 112 return; 113 114 #ifdef CONFIG_NF_CONNTRACK_TIMESTAMP 115 /* renew only if this is the first cached event, so that the 116 * timestamp reflects the first, not the last, generated event. 117 */ > 118 if (local64_read(&e->timestamp) && READ_ONCE(e->cache) == 0) > 119 local64_set(&e->timestamp, ktime_get_real_ns()); 120 #endif 121 122 set_bit(event, &e->cache); 123 #endif 124 } 125 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
