Re: [PATCH nft] tests: monitor: run-tests.sh: restore cwd before unshare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 07, 2024 at 01:56:53PM +0100, Florian Westphal wrote:
> The monitor script no longer works if not called from tests/monitor directory:
> 
> % tests/monitor/run-tests.sh
> unshare: failed to execute tests/monitor/run-tests.sh: No such file or directory
> 
> ... because the script will change the directory.
> Stash and restore to old one so unshare $0 can work.

Still not perfect:

| % sudo ./tests/monitor/run-tests.sh ./tests/monitor/testcases/set-maps.t 
| /home/n0-1/git/nftables /home/n0-1/git/nftables
| /home/n0-1/git/nftables
| /home/n0-1/git/nftables /home/n0-1/git/nftables
| unknown option './tests/monitor/testcases/set-maps.t'
| Usage: run-tests.sh [-j|--json] [-d|--debug] [testcase ...]

AFAICT, $(dirname $0) is only needed to locate the local nft binary. Let
me send a patch which eliminates the cd call entirely.

Cheers, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux