Re: [conntrack-tools PATCH] src: Eliminate warnings with -Wcalloc-transposed-args

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 06, 2024 at 12:17:32AM +0100, Phil Sutter wrote:
> On Wed, Nov 06, 2024 at 12:10:02AM +0100, Pablo Neira Ayuso wrote:
> > On Tue, Nov 05, 2024 at 10:54:50PM +0100, Phil Sutter wrote:
> > > calloc() expects the number of elements in the first parameter, not the
> > > second. Swap them and while at it drop one pointless cast (the function
> > > returns a void pointer anyway).
> > 
> > BTW, will you add
> > 
> > -Wcalloc-transposed-args
> > 
> > to Makefile.am?
> 
> The gcc-14.2.1_p20240921 here seems to have this enabled by default. I
> did not pass any special configure or make options.

I was expecting something like this, thanks for confirming.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux