Hi Florian, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/netfilter-nf_tables-avoid-false-positive-lockdep-splat-on-rule-deletion/20241030-174657 base: https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main patch link: https://lore.kernel.org/r/20241030094053.13118-8-fw%40strlen.de patch subject: [PATCH v2 nf-next 7/7] netfilter: nf_tables: must hold rcu read lock while iterating object type list config: s390-randconfig-r073-20241031 (https://download.01.org/0day-ci/archive/20241101/202411010754.SLk5GvT6-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202411010754.SLk5GvT6-lkp@xxxxxxxxx/ New smatch warnings: net/netfilter/nf_tables_api.c:7886 nf_tables_newobj() warn: 'type' is an error pointer or valid vim +/type +7886 net/netfilter/nf_tables_api.c 7dab8ee3b6e7ec8 Pablo Neira Ayuso 2021-04-23 7879 if (info->nlh->nlmsg_flags & NLM_F_REPLACE) d62d0ba97b58031 Fernando Fernandez Mancera 2019-08-26 7880 return -EOPNOTSUPP; d62d0ba97b58031 Fernando Fernandez Mancera 2019-08-26 7881 84b1a0c0140a9a9 Pablo Neira Ayuso 2024-03-05 7882 if (!obj->ops->update) 84b1a0c0140a9a9 Pablo Neira Ayuso 2024-03-05 7883 return 0; 84b1a0c0140a9a9 Pablo Neira Ayuso 2024-03-05 7884 2a7dbf052c3b79b Florian Westphal 2024-10-30 7885 type = nft_obj_type_get(net, objtype, family); 2a7dbf052c3b79b Florian Westphal 2024-10-30 @7886 if (WARN_ON_ONCE(!type)) s/!type/IS_ERR(type)/ 2a7dbf052c3b79b Florian Westphal 2024-10-30 7887 return -ENOENT; 2a7dbf052c3b79b Florian Westphal 2024-10-30 7888 7dab8ee3b6e7ec8 Pablo Neira Ayuso 2021-04-23 7889 nft_ctx_init(&ctx, net, skb, info->nlh, family, table, NULL, nla); d62d0ba97b58031 Fernando Fernandez Mancera 2019-08-26 7890 2a7dbf052c3b79b Florian Westphal 2024-10-30 7891 /* type->owner reference is put when transaction object is released. */ d62d0ba97b58031 Fernando Fernandez Mancera 2019-08-26 7892 return nf_tables_updobj(&ctx, type, nla[NFTA_OBJ_DATA], obj); e50092404c1bc7a Pablo Neira Ayuso 2016-11-28 7893 } e50092404c1bc7a Pablo Neira Ayuso 2016-11-28 7894 7dab8ee3b6e7ec8 Pablo Neira Ayuso 2021-04-23 7895 nft_ctx_init(&ctx, net, skb, info->nlh, family, table, NULL, nla); e50092404c1bc7a Pablo Neira Ayuso 2016-11-28 7896 1689f25924ada8f Pablo Neira Ayuso 2023-06-28 7897 if (!nft_use_inc(&table->use)) 1689f25924ada8f Pablo Neira Ayuso 2023-06-28 7898 return -EMFILE; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
