Re: [nf-next PATCH v3 06/16] netfilter: nf_tables: Tolerate chains with no remaining hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 31, 2024 at 03:37:36PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@xxxxxx> wrote:
> > AFAIR, we did just that in the past with such cases. I agree, it pretty
> > much breaks any efforts at making the testsuite usable with stable
> > kernels.
> > 
> > > Should the dump files be removed?
> > 
> > Maybe "feature flag" it and introduce a mechanism for test cases to
> > revert to a different dump file?
> 
> What could be good enough:
> 1. fix dump files
> 2. add feature flag, if feature not present -> exit 77/skip to elide
> dump compare.

Reasonably simple to provide backwards compat (and still keeping the
actual test active)!

> Would you explore this?

Will do!

Thanks, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux