Re: [PATCH nft] tests: monitor: fix up test case breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 31, 2024 at 12:29:14AM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > I can also revert the patch if you don't like, but it is saving _a
> > lot_ of memory from userspace for the silly one element per line case.
> 
> I think your patch is fine, the question is if we should ditch the
> test case instead of reordering the expected output.

ACK, that was my thought. Looking at the test case and seeing how later
tests depend on these elements being present, dropping it is not
practical though. We could reorder the I lines to match output, but the
commit is upstream already, so ... nevermind. :)

Thanks for the fix and clarification, guys!

Cheers, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux