On Mon, Oct 28, 2024 at 04:13:51PM +0100, Pablo Neira Ayuso wrote: > 8c873e219970 ("netfilter: core: free hooks with call_rcu") removed > synchronize_net() call when unregistering basechain hook, however, > net_device removal event handler for the NFPROTO_NETDEV was not updated > to wait for RCU grace period. > > Note that 835b803377f5 ("netfilter: nf_tables_netdev: unregister hooks > on net_device removal") does not remove basechain rules on device > removal, it was just a bit later that I was hinted to remove rules on > net_device removal, see 5ebe0b0eec9d ("netfilter: nf_tables: destroy > basechain and rules on netdevice removal"). I have to scratch this patch, I am seeing an issue with it, sorry for the noise.