On Fri, Oct 25, 2024 at 01:22:30AM +0200, Florian Westphal wrote: > Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > > > this comment below is also not valid anymore: > > > > /* called with rcu_read_lock held */ > > static struct sk_buff * > > nf_tables_getrule_single(u32 portid, const struct nfnl_info *info, > > const struct nlattr * const nla[], bool reset) > > Yes, either called with rcu read lock or commit mutex held. > > > This is not the only spot that can trigger rcu splats. > > Agree. Will you make a patch or should I take a look? > I'm leaning towards a common helper that can pass the > right lockdep annotation, i.e. pass nft_net as arg to > document when RCU or transaction semantics apply. Please, go ahead if you have the time. Thanks.