Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > I did not yet add new enum values or a dedicated nf namespace > > (enum skb_drop_reason_subsys), because I did not see a reason and > > wasn't sure if we'd need sub-subsystems (nf_tables, conntrack, nat, > > whatever). > > Does this mean values exposed through tracing infrastructure can > change or these are part of uapi? The enum has had values added (not just appended), so its not considered uapi. > From what I read from you, I > understand it is possible to change SKB_DROP_REASON_NETFILTER_DROP to > a more specific sub-subsystem tag in the future without issues. Thats correct. > > If you like, I can add NF_FREE_SKB(skb, errno) and rework this > > set to use that? > > Not strong about this. I was exploring if it should be possible to > remove (repetitive) information in the code that can be assumed to be > implicit, I still like the word "REASON" in the macro for grepping. Yes, common name is good. > I think we can just move on with this series as-is if you prefer and > add new macros incrementally to refine. I think we can refine later if there are use-cases for that.
