Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > > That would work too. I don't really get mnl_attr_type_valid(). > > mnl_attr_type_valid() can go away if all switch() are audited, yes, it > is just defensive. > > All of the callbacks have a switch statement, so anything not handled > > is 'unknown'. > > But if you prefer the mnl_attr_type_valid() use then I can rewrite it. > > There is also _PAD attributes that maybe trigger default case. Right, I'll probably change it to only care about 'mnl_attr_type_valid returns false'.
