Re: [PATCH libnetfilter_queue] build: add missing backslash to build_man.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phil,

On Fri, Oct 04, 2024 at 03:18:28PM +0200, Phil Sutter wrote:
> This holds another interesting detail, though: By quoting your
> delimiter, you may disable expansion entirely which might improve
> readability in those ed commands?

I did try quoting the delimiter when I was working on speeding up build_man.sh.
Rather to my surprise, the used CPU went up albeit by a tiny amount. I was
absolutely focussed on speed so left the delimiter unquoted.

The CPU increase was so small that you might consider the improvement in
readability to be worth it.

But there is another possible downside to quoting the delimiter. Some of the
here documents in build_man contain actual parameter substitution so would have
to be left as_is, leading to inconsistent appearance of here documents.

I'm happy to do it either way, LMK your preference.

Cheers ... Duncan.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux