On 9/26/24 12:37, Florian Westphal wrote:
Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
On 9/24/24 22:13, Pablo Neira Ayuso wrote:
The following patchset contains Netfilter fixes for net:
Patch #1 and #2 handle an esoteric scenario: Given two tasks sending UDP
packets to one another, two packets of the same flow in each direction
handled by different CPUs that result in two conntrack objects in NEW
state, where reply packet loses race. Then, patch #3 adds a testcase for
this scenario. Series from Florian Westphal.
Kdoc complains against the lack of documentation for the return value in the
first 2 patches: 'Returns' should be '@Return'.
:-(
Apparently this is found via
scripts/kernel-doc -Wall -none <file>
I'll run this in the future, but, I have to say, its encouraging me
to just not write such kdocs entries in first place, no risk of making
a mistake.
Paolo, Pablo, what should I do now?
If an updated PR could be resent soon, say within ~1h, I can wait for
the CI to run on it, merge and delay the net PR after that.
Otherwise, if the fixes in here are urgent, I can pull the series as-is,
and you could follow-up on nf-next/net-next.
The last resort is just drop this from today's PR.
Please LMK your preference,
Paolo
