Re: [nf-next PATCH v4 15/16] netfilter: nf_tables: Add notications for hook changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Phil Sutter <phil@xxxxxx> wrote:
> > This relies on implicit NFNL_CB_UNSPEC == 0 and nfnetlink
> > bailing out whe NFT_MSG_NEWDEV appears in a netlink message
> > coming from userspace.
> 
> I guess with 'implicit NFNL_CB_UNSPEC == 0' you mean the extra
> nf_tables_cb array fields' 'type' value being 0 (nfnetlink.h explicitly
> defines NFNL_CB_UNSPEC value as 0). I don't see the connection here
> though, probably I miss nfnetlink_rcv_msg() relying on that field value
> or so.

I should have been more clear, I was wondering if we need/want
an -EOPNOTSUPP stub callback rather than reliance of nfnetlink to
detect it.

> I see at least NFNL_MSG_ACCT_OVERQUOTA missing from nfnl_acct_cb. The
> former was introduced in 2014. May I claim grandfathering? ;)

I guess it just means "no we don't worry about it".




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux