Re: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
From: Florian Westphal <fw@xxxxxxxxx>
Date: Thu, 19 Sep 2024 12:49:22 +0200
Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Florian Westphal <fw@xxxxxxxxx>
In-reply-to: <20240919104503.20821-1-phil@nwl.cc>
User-agent: Mutt/1.10.1 (2018-07-13)

Phil Sutter <phil@xxxxxx> wrote:
> Make sure writers won't free the current hook being dereferenced.

Are you sure?
AFAICS its only called from eval function/hook plane, those are already
rcu locked.

Follow-Ups:
- Re: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
  - From: Phil Sutter

References:
- [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
  - From: Phil Sutter

Prev by Date: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
Next by Date: Re: [RFC PATCH v3 12/19] selftests/landlock: Test that kernel space sockets are not restricted
Previous by thread: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
Next by thread: Re: [nf PATCH] netfilter: nf_tables: nft_flowtable_find_dev() lacks rcu_read_lock()
Index(es):
- Date
- Thread

[Index of Archives] [Netfitler Users] [Berkeley Packet Filter] [LARTC] [Bugtraq] [Yosemite Forum]

Powered by Linux